Fix flaky MinHasherSpec test. Fixes #500
#514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One `MinHasher32` being tested was using 247 hash functions internally, which
means that the expected absolute error bound:
1 / sqrt {# of hash functions} = 1 / sqrt 247 ~ 0.064
The same test required an upper bound on the error of `0.05`, which was below
the expected error bound, meaning that this test would give flaky results due to
occasionally exceeding the required error bound. This change increases the
upper bound on the error to 0.1 which should give enough headroom over the
expected error bound to reduce the number of random test failures.
| @@ -56,7 +56,7 @@ class MinHasherSpec extends WordSpec with Matchers { | |||
| test(new MinHasher32(0.5, 1024), 0.5, 0.1) | |||
| } | |||
| "measure 0.8 similarity in 1024 bytes with < 0.05 error" in { | |||
|
👍 |
johnynek
added a commit
that referenced
this pull request
Feb 26, 2016
Fix flaky `MinHasherSpec` test. Fixes #500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One
MinHasher32being tested was using 247 hash functions internally, whichmeans that the expected absolute error bound:
The same test required an upper bound on the error of
0.05, which was belowthe expected error bound, meaning that this test would give flaky results due to
occasionally exceeding the required error bound. This change increases the
upper bound on the error to 0.1 which should give enough headroom over the
expected error bound to reduce the number of random test failures.