Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #326 - Some HyperLogLog tests are not testing what we think. #923

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

enricoap
Copy link
Contributor

Issue #326

Proposed Changes for the jRhoW test

  • the size of the Array[Byte] in input in input of the jRhoW function is now dependent on the number of bits.

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2021

CLA assistant check
All committers have signed the CLA.

@johnynek
Copy link
Collaborator

Thanks for the PR.

Can you run scalafmt at the sbt prompt?

I'm happy to merge this. I guess previously we just never hit a case that had to go very far into the array.

@enricoap
Copy link
Contributor Author

Sorry, I just saw this comment now. Will do!

@codecov-io
Copy link

Codecov Report

Merging #923 (9c141e4) into develop (ff8b0e6) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #923      +/-   ##
===========================================
- Coverage    89.67%   89.59%   -0.09%     
===========================================
  Files          119      119              
  Lines         9869     9869              
  Branches       494      494              
===========================================
- Hits          8850     8842       -8     
- Misses        1019     1027       +8     
Impacted Files Coverage Δ
...main/scala/com/twitter/algebird/monad/Reader.scala 52.94% <0.00%> (-5.89%) ⬇️
...src/main/scala/com/twitter/algebird/Interval.scala 75.65% <0.00%> (-5.22%) ⬇️
...a/com/twitter/algebird/immutable/BloomFilter.scala 95.08% <0.00%> (-0.82%) ⬇️
.../scala/com/twitter/algebird/immutable/BitSet.scala 96.57% <0.00%> (-0.22%) ⬇️
.../main/scala/com/twitter/algebird/BloomFilter.scala 94.24% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8b0e6...9c141e4. Read the comment docs.

@johnynek johnynek merged commit b699307 into twitter:develop Feb 24, 2021
@johnynek
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants