Clean up logging shim #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 7, 2019 17:00
brayniac
suggested changes
Oct 8, 2019
rust/ccommon_rs/src/log/shim.rs
Outdated
| /// | ||
| /// This is meant to be | ||
| pub fn set_panic_handler() { | ||
| use backtrace::Backtrace; |
There was a problem hiding this comment.
Will the backtrace dependency be compatible w/ MUSL builds? Can we add x86_64-unknown-linux-musl target to the CI to make sure? I've had problems w/ backtrace + musl historically, but looks like it might be fixed now?
There was a problem hiding this comment.
I've redone this to use the standard lib's backtrace printing. That should (hopefully) avoid any issues around musl and the backtrace crate
brayniac
approved these changes
Oct 8, 2019
swlynch99
force-pushed
the
clean-up-log
branch
from
22a90a6 to
7785897
Compare
swlynch99
force-pushed
the
clean-up-log
branch
from
7785897 to
c8ddb11
Compare
swlynch99
pushed a commit
to swlynch99/pelikan-twitter
that referenced
this pull request
Oct 9, 2019
swlynch99
pushed a commit
to twitter/pelikan
that referenced
this pull request
Oct 10, 2019
swlynch99
added a commit
that referenced
this pull request
Oct 16, 2019
This originally tested code that was removed in #218 but was missed because the rust parts of the test are never built even when -DHAVE_RUST=1 is specified in the cmake configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the log shim in ccommon_rs to be both simpler and usable from the rust code. This addresses a few problems with the original log module, namely that
The new version just passes log messages through to ccommon's debug log. In addition, I've added a panic hook that logs at
LOG_CRITlevel.As a result of this, several other changes were made:
rm -rfimplementation)