Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: add note about supported scala versions #474

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

unkarjedy
Copy link
Contributor

#473 (comment)

If you have time to update the file to mention 2.13 that would be great.
Also we may have dropped 2.10, I thought we did but I'm on a phone now.

twitter#473 (comment)

>If you have time to update the file to mention 2.13 that would be great.
Also we may have dropped 2.10, I thought we did but I'm on a phone now.
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #474 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #474   +/-   ##
========================================
  Coverage    91.69%   91.69%           
========================================
  Files           42       42           
  Lines         1396     1396           
  Branches        35       35           
========================================
  Hits          1280     1280           
  Misses         116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c292fac...af7361b. Read the comment docs.

Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! can you remove the 2.10 reference?

Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@regadas regadas merged commit 56a022e into twitter:develop Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants