Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chill-protobuf with protobuf 3.17.1 #571

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Update chill-protobuf with protobuf 3.17.1 #571

merged 3 commits into from
Jun 4, 2021

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented Jun 3, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #571 (2c4543f) into develop (93e4cba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #571   +/-   ##
========================================
  Coverage    91.69%   91.69%           
========================================
  Files           42       42           
  Lines         1397     1397           
  Branches        32       32           
========================================
  Hits          1281     1281           
  Misses         116      116

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e4cba...2c4543f. Read the comment docs.

@regadas regadas mentioned this pull request Jun 3, 2021
Merged
johnynek
johnynek requested changes Jun 3, 2021
View reviewed changes
chill-protobuf/src/test/protobuf/test_messages.proto Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
johnynek
johnynek approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the pom looks clean, happy to merge now.

Thanks for taking this.

@johnynek johnynek mentioned this pull request Jun 4, 2021
Closed
@regadas
Copy link
Collaborator Author

regadas commented Jun 4, 2021

@johnynek Thanks for the review! I'll go ahead and do a release 0.10.0 since we have some breaking changes.

@regadas regadas merged commit 9bb3bdf into twitter:develop Jun 4, 2021
@regadas regadas deleted the update_proto branch June 4, 2021 21:40
regadas added a commit that referenced this pull request Jun 4, 2021
@regadas
Update chill-protobuf with protobuf 3.17.1 (#571)
0a34e50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnynek johnynek johnynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regadas @codecov-commenter @johnynek