redis protocol: tokenizer, hash and zset #146

thinkingfish · 2017-03-03T20:49:15Z

tokenizer deals with the basic serialization types. It currently handles all the elemental types but not nested arrays.

as far as parser is concerned the amount of work on top of tokenizer is minimum. The variable part of the argument list will be handled by processing logic.

ce0b9ea allow printing negative integers in cc_print (twitter#141) ab0edc8 add metrics to track buf_sock objects (twitter#138) ae02038 add travis ci (copied from pelikan) (twitter#139) 964645a Merge pull request twitter#135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request twitter#126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request twitter#133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request twitter#127 from kevyang/56 780941a Merge pull request twitter#130 from kevyang/129 b8af6c0 Merge pull request twitter#131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: ce0b9ea

b1babb2 change wheel's sleep timer to make it less flaky (twitter#143) git-subtree-dir: deps/ccommon git-subtree-split: b1babb2

kevyang · 2017-03-22T22:45:31Z

src/protocol/data/redis/compose.h

+    COMPOSE_ENOMEM      = -2,
+    COMPOSE_EINVALID    = -3,
+    COMPOSE_EOTHER      = -4,
+} compose_rstatus_t;


According to the coding style guidelines, this should be compose_rstatus_i

kevyang · 2017-03-22T22:52:18Z

src/protocol/data/redis/token.c

+        }
+    }
+
+    return CC_OK;


kevyang · 2017-03-22T23:07:09Z

src/protocol/data/redis/token.c

+    if (status != PARSE_OK) {
+        return status;
+    }
+    if (len < 0) {


what if len == 0?

kevyang · 2017-03-22T23:19:29Z

src/protocol/data/redis/token.c

+    p = buf->rpos++;
+    switch (*p) {
+    case '+':
+        /* imple string */


kevyang · 2017-03-22T23:20:50Z

src/protocol/data/redis/token.c

+    struct buf *b;
+    size_t n = 1 + CRLF_LEN + CC_INT64_MAXLEN;
+
+    if (_check_buf_size(buf, n) != CC_OK) {


kevyang

will continue reviewing later

seppo0010 · 2017-03-24T02:30:18Z

deps/ccommon/src/cc_print.c

+
+    _print_uint64(buf, d, n);
+
+    return (n < 0) ? d + 1 : d;


I believe this could be simplified a little further... since we decrement d when n < 0, we could not do that and just return d? now that I see it, it makes sense, as d is the original calculation for the number of bytes needed 😂

seppo0010 · 2017-03-24T02:32:04Z

src/protocol/data/redis/cmd_hash.h

+    ACTION( REQ_HVALS,          "hvals",        2  )\
+    ACTION( REQ_HSCAN,          "hscan",        -3 )
+
+/* "hlen KEY" == "*2\r\n$4\r\nhlen\r\n$3\r\nKEY\r\n" */


seppo0010 · 2017-03-24T02:52:17Z

src/protocol/data/redis/parse.c

+
+    status = _parse_cmd(req);
+    if (status != PARSE_OK) {
+        return status;


buf->rpos = old_rpos;?

seppo0010 · 2017-03-24T03:02:32Z

src/protocol/data/redis/parse.h

+void parse_teardown(void);
+
+static inline bool
+key_valid(struct bstring *key)


seppo0010 · 2017-03-24T03:05:25Z

src/protocol/data/redis/request.c

+
+    status = array_create(&req->token, ntoken, sizeof(struct element));
+    if (status != CC_OK) {
+        return NULL;


cc_free(req);? do we care?

seppo0010 · 2017-03-24T03:34:25Z

test/protocol/data/redis/check_redis.c

+START_TEST(test_simple_string)
+{
+#define SERIALIZED "+foobar\r\n"
+#define STR "foobar"


how about this?

#define STR "foobar" #define SERIALIZED "+" STR "\r\n"

(this comment also applies for many tests below)

seppo0010 · 2017-03-24T03:38:20Z

test/protocol/data/redis/check_redis.c

+    ck_assert_int_eq(cc_bcmp(buf->rpos, SERIALIZED, ret), 0);
+
+    /* parse */
+    pos = buf->rpos + 1;


reusing el from the compose section makes this test less reliable as the production code may be not setting a property that is set by the previous portion of the test; break it up into two tests? use a second el-like variable instead? destroy its value in between?

(this comment also applies for many tests below)

seppo0010 · 2017-03-24T03:45:34Z

test/protocol/data/redis/check_redis.c

+
+    /* simple ping */
+    buf_write(buf, S_PING, sizeof(S_PING) - 1);
+    ck_assert_int_eq(parse_req(req, buf), PARSE_OK);


ck_assert_int_eq(req->type, REQ_PING);

seppo0010 · 2017-03-24T03:48:24Z

test/protocol/data/redis/check_redis.c

+END_TEST
+
+START_TEST(test_integer)
+{


test oversize?

seppo0010 · 2017-03-24T03:51:25Z

test/protocol/data/redis/check_redis.c

+#undef QUIT
+}
+END_TEST
+


add test for incomplete bulk and another one for multi bulk (maybe even one case for each element type if you feel like it) and check that it returns EUNFIN and resets rpos

kevyang · 2017-03-24T20:25:29Z

src/protocol/data/redis/response.c

+#include <cc_mm.h>
+#include <cc_pool.h>
+
+#define RESPONSE_MODULE_NAME "protocol::memcache::response"


protocol::redis::response

kevyang · 2017-03-24T20:38:25Z

I guess I am kind of confused as to what exactly the purpose/scope of the token.[ch] module is. It seems to me that it can mostly be folded into parse and compose; why is it its own module?

9264bbb Zero byte (twitter#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (twitter#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (twitter#145) git-subtree-dir: deps/ccommon git-subtree-split: 9264bbb

seppo0010

test_unfin is beautiful 😍

seppo0010 · 2017-04-02T06:43:34Z

src/protocol/data/redis/token.c

+
+                return PARSE_OK;
+            } else {
+                if (*buf->rpos == CR) {


if len is 0 shouldn't this return EINVALID? e.g.: $\r\n

seppo0010 · 2017-04-02T06:52:13Z

src/protocol/data/redis/token.c

+        return COMPOSE_EINVALID;
+    }
+
+    if (_check_buf_size(buf, n) != CC_OK) {


s/CC_OK/COMPOSE_OK/

seppo0010 · 2017-04-02T06:57:51Z

src/protocol/data/redis/token.c

+
+    switch (el->type) {
+    case ELEM_STR:
+        n = buf_write(b, "+", 1) + _write_bstr(b, &el->bstr);


I believe C does not guarantee the functions will be called left to right. http://stackoverflow.com/a/4737379

Break these down into two statements:

n = buf_write(b, "+", 1); n += _write_bstr(b, &el->bstr);

seppo0010 · 2017-04-02T07:02:10Z

test/protocol/data/redis/check_redis.c

+#define INT_2 9223372036854775807LL
+#define INT_3 128
+#define OVERSIZE ":19223372036854775807\r\n"
+#define INVALID ":123lOl456\r\n"


#define INVALID_2 ":\r\n"

seppo0010 · 2017-04-02T07:05:09Z

test/protocol/data/redis/check_redis.c

+    ck_assert_int_eq(cc_bcmp(buf->rpos, SERIALIZED_3, ret), 0);
+    ret = parse_element(&el_p, buf);
+    ck_assert_int_eq(ret, PARSE_OK);
+    ck_assert(el_p.num == INT_3);


missing ck_assert(el_p.type == ELEM_INT);

these three could use a local macro to avoid duplication?

#define TEST_SERIALIZE(value, serialized)\ buf_reset(buf);\ el_c.num = value;\ ret = compose_element(&buf, &el_c);\ ck_assert(ret == sizeof(serialized) - 1);\ ck_assert_int_eq(cc_bcmp(buf->rpos, serialized, ret), 0);\ ret = parse_element(&el_p, buf);\ ck_assert_int_eq(ret, PARSE_OK);\ ck_assert(el_p.type == ELEM_INT);\ ck_assert(el_p.num == value); TEST_SERIALIZE(INT_1, SERIALIZED_1); TEST_SERIALIZE(INT_2, SERIALIZED_2); TEST_SERIALIZE(INT_3, SERIALIZED_3); #undef TEST_SERIALIZE

727905b adding a new API to duration timer (twitter#152) 9406717 add missing "extern C" qualifiers to a few headers for C++ linking; (twitter#150) a0aafdf Add missing semicolon to ring array example code in documentation. (twitter#149) 9264bbb Zero byte (twitter#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (twitter#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (twitter#145) b1babb2 change wheel's sleep timer to make it less flaky (twitter#143) ce0b9ea allow printing negative integers in cc_print (twitter#141) ab0edc8 add metrics to track buf_sock objects (twitter#138) ae02038 add travis ci (copied from pelikan) (twitter#139) 964645a Merge pull request twitter#135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request twitter#126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request twitter#133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request twitter#127 from kevyang/56 780941a Merge pull request twitter#130 from kevyang/129 b8af6c0 Merge pull request twitter#131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: 727905b

727905b adding a new API to duration timer (#152) 9406717 add missing "extern C" qualifiers to a few headers for C++ linking; (#150) a0aafdf Add missing semicolon to ring array example code in documentation. (#149) 9264bbb Zero byte (#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (#145) b1babb2 change wheel's sleep timer to make it less flaky (#143) ce0b9ea allow printing negative integers in cc_print (#141) ab0edc8 add metrics to track buf_sock objects (#138) ae02038 add travis ci (copied from pelikan) (#139) 964645a Merge pull request #135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request #126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request #133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request #127 from kevyang/56 780941a Merge pull request #130 from kevyang/129 b8af6c0 Merge pull request #131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: 727905b

dd56abd break up ASSERT in buf_sock_read (twitter#153) 727905b adding a new API to duration timer (twitter#152) 9406717 add missing "extern C" qualifiers to a few headers for C++ linking; (twitter#150) a0aafdf Add missing semicolon to ring array example code in documentation. (twitter#149) 9264bbb Zero byte (twitter#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (twitter#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (twitter#145) b1babb2 change wheel's sleep timer to make it less flaky (twitter#143) ce0b9ea allow printing negative integers in cc_print (twitter#141) ab0edc8 add metrics to track buf_sock objects (twitter#138) ae02038 add travis ci (copied from pelikan) (twitter#139) 964645a Merge pull request twitter#135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request twitter#126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request twitter#133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request twitter#127 from kevyang/56 780941a Merge pull request twitter#130 from kevyang/129 b8af6c0 Merge pull request twitter#131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: dd56abd

* consolidate code a bit * Squashed 'deps/ccommon/' changes from bb298bc..dd56abd dd56abd break up ASSERT in buf_sock_read (#153) 727905b adding a new API to duration timer (#152) 9406717 add missing "extern C" qualifiers to a few headers for C++ linking; (#150) a0aafdf Add missing semicolon to ring array example code in documentation. (#149) 9264bbb Zero byte (#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (#145) b1babb2 change wheel's sleep timer to make it less flaky (#143) ce0b9ea allow printing negative integers in cc_print (#141) ab0edc8 add metrics to track buf_sock objects (#138) ae02038 add travis ci (copied from pelikan) (#139) 964645a Merge pull request #135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request #126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request #133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request #127 from kevyang/56 780941a Merge pull request #130 from kevyang/129 b8af6c0 Merge pull request #131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: dd56abd

a2d5c01 add a function that will reject all pending incoming connections (twitter#154) dd56abd break up ASSERT in buf_sock_read (twitter#153) 727905b adding a new API to duration timer (twitter#152) 9406717 add missing "extern C" qualifiers to a few headers for C++ linking; (twitter#150) a0aafdf Add missing semicolon to ring array example code in documentation. (twitter#149) 9264bbb Zero byte (twitter#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (twitter#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (twitter#145) b1babb2 change wheel's sleep timer to make it less flaky (twitter#143) ce0b9ea allow printing negative integers in cc_print (twitter#141) ab0edc8 add metrics to track buf_sock objects (twitter#138) ae02038 add travis ci (copied from pelikan) (twitter#139) 964645a Merge pull request twitter#135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request twitter#126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request twitter#133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request twitter#127 from kevyang/56 780941a Merge pull request twitter#130 from kevyang/129 b8af6c0 Merge pull request twitter#131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: a2d5c01

6b59401 Rust build tweak (twitter#165) b39086d fix docs to new ring_array_destroy semantics (twitter#163) 95e04b0 Additional ring_array API (twitter#159) 3c994cc a single job in the travis-ci matrix for building with rust enabled (twitter#161) 1fe907e rust support - Native bstrings (twitter#160) b3de2ee add HAVE_RUST option defaulted to off (twitter#158) ffc70a8 Port travis ci changes - closes twitter#186 (twitter#155) a2d5c01 add a function that will reject all pending incoming connections (twitter#154) dd56abd break up ASSERT in buf_sock_read (twitter#153) 727905b adding a new API to duration timer (twitter#152) 9406717 add missing "extern C" qualifiers to a few headers for C++ linking; (twitter#150) a0aafdf Add missing semicolon to ring array example code in documentation. (twitter#149) 9264bbb Zero byte (twitter#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (twitter#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (twitter#145) b1babb2 change wheel's sleep timer to make it less flaky (twitter#143) ce0b9ea allow printing negative integers in cc_print (twitter#141) ab0edc8 add metrics to track buf_sock objects (twitter#138) ae02038 add travis ci (copied from pelikan) (twitter#139) 964645a Merge pull request twitter#135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request twitter#126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request twitter#133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request twitter#127 from kevyang/56 780941a Merge pull request twitter#130 from kevyang/129 b8af6c0 Merge pull request twitter#131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: 6b59401

f5efe29 forgot to remove unused include (#167) 441934b update ring_array docs for new API, add multi threaded unit test for ring_array (#166) 67ce9c2 Adding issue and pull request templates to comply with twitter OSS policies (#151) 6b59401 Rust build tweak (#165) b39086d fix docs to new ring_array_destroy semantics (#163) 95e04b0 Additional ring_array API (#159) 3c994cc a single job in the travis-ci matrix for building with rust enabled (#161) 1fe907e rust support - Native bstrings (#160) b3de2ee add HAVE_RUST option defaulted to off (#158) ffc70a8 Port travis ci changes - closes #186 (#155) a2d5c01 add a function that will reject all pending incoming connections (#154) dd56abd break up ASSERT in buf_sock_read (#153) 727905b adding a new API to duration timer (#152) 9406717 add missing "extern C" qualifiers to a few headers for C++ linking; (#150) a0aafdf Add missing semicolon to ring array example code in documentation. (#149) 9264bbb Zero byte (#147) (emergency fix needed for pelikan) d4002d7 simplify cc_print_int64 (#146) b164fcf Clean-up hash functions and introduce MurmurHash3 (#145) b1babb2 change wheel's sleep timer to make it less flaky (#143) ce0b9ea allow printing negative integers in cc_print (#141) ab0edc8 add metrics to track buf_sock objects (#138) ae02038 add travis ci (copied from pelikan) (#139) 964645a Merge pull request #135 from paegun/fix_cmake_install 70710c2 fixed and re-added cmake install instructions, w/ following notes: include directory made proper relative; opened pattern match b/c include directory should only contain files meant for inclusion. 5b095bc Merge pull request #126 from kevyang/kevyang/120 426d56a return NULL when cc_alloc/cc_realloc is called with size == 0 ad271d4 Merge pull request #133 from kevyang/132 47dbdba suppress unused parameter warning in debug_log_flush 648d19e Merge pull request #127 from kevyang/56 780941a Merge pull request #130 from kevyang/129 b8af6c0 Merge pull request #131 from kevyang/128 6ecc318 fix duplicate symbols in cc_signal 080c41d cc_array - stop doing arithmetic on void * d526f7a add debug oriented memory management a4fb927 Update bool member rules in style guide 05c6e1e explicitly make ccommon a C project to avoid checking for CXX related variables git-subtree-dir: deps/ccommon git-subtree-split: f5efe29

* simply cc_print_int64 * use the same return statement as in cc_print_int64() * disable flaky test until we have a mock timer

Yao Yue added 6 commits March 3, 2017 20:19

initial check-in of redis protocol: tokenizer

a3e86dd

update osx entries in travis

e36ef0d

compose/parse commands

d3c2b23

Merge commit '5a99512ae362cdbbab8e1529fd6f63648524f855' into redis_codec

b479f18

use new macro imported from ccommon

9b0c137

thinkingfish changed the title ~~initial check-in of redis protocol: tokenizer~~ redis protocol: tokenizer, hash and zset Mar 20, 2017

Yao Yue added 8 commits March 20, 2017 10:37

more tests

2eefb54

modify response for redis

bf19106

add response check

96f5780

add response parse/compose

03e5811

Squashed 'deps/ccommon/' changes from ce0b9ea..b1babb2

e7957bd

b1babb2 change wheel's sleep timer to make it less flaky (twitter#143) git-subtree-dir: deps/ccommon git-subtree-split: b1babb2

Merge commit 'e7957bd1fa3a62a9d89c2bc9cc8845b970ebf48b' into redis_codec

5c2e1dc

grep for error in unittest logs

b6f24df

change nelem type in token_array_nelem

05e76b0

kevyang reviewed Mar 22, 2017

View reviewed changes

src/protocol/data/redis/token.c Outdated

}

}

return CC_OK;

Copy link

Contributor

kevyang Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMPOSE_OK

This comment was marked as spam.

Sign in to view

kevyang reviewed Mar 22, 2017

View reviewed changes

kevyang suggested changes Mar 22, 2017

View reviewed changes

changes reflected Kevin's review on Mar 22

dce2940

seppo0010 reviewed Mar 24, 2017

View reviewed changes

kevyang reviewed Mar 24, 2017

View reviewed changes

This comment was marked as spam.

Sign in to view

Yao Yue added 4 commits April 1, 2017 17:08

address most comments

b2d965a

Merge commit 'de0fc63fd246da677eb83b8b0f7e08000eb927f1' into redis_codec

030a493

changes needed to use new hash function names

96e3e4e

Yao Yue added 2 commits April 1, 2017 19:34

add more tests and fix corresponding bugs

2929445

temporarily disable flaky build

c6d1970

seppo0010 suggested changes Apr 2, 2017

View reviewed changes

Yao Yue added 2 commits April 2, 2017 12:49

feedback from seppo0010

df00783

adding comment to token.h

c3c617f

seppo0010 approved these changes Apr 2, 2017

View reviewed changes

thinkingfish merged commit 8a7e319 into twitter:master Apr 4, 2017

thinkingfish deleted the redis_codec branch April 22, 2017 00:07

swlynch99 pushed a commit to swlynch99/pelikan-twitter that referenced this pull request Sep 30, 2019

simplify cc_print_int64 (twitter#146)

d4002d7

* simply cc_print_int64 * use the same return statement as in cc_print_int64() * disable flaky test until we have a mock timer

redis protocol: tokenizer, hash and zset #146

redis protocol: tokenizer, hash and zset #146

Conversation

thinkingfish commented Mar 3, 2017 • edited Loading

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

kevyang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

kevyang commented Mar 24, 2017

This comment was marked as spam.

seppo0010 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

seppo0010 Apr 2, 2017 • edited Loading

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

Choose a reason for hiding this comment

This comment was marked as spam.

seppo0010 Apr 2, 2017 • edited Loading

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

thinkingfish commented Mar 3, 2017 •

edited

Loading

seppo0010 Apr 2, 2017 •

edited

Loading

seppo0010 Apr 2, 2017 •

edited

Loading