bugfix: interrupts sampler per-node nvme and network metrics (#226)

As noted in #224, we improperly initialize the per-node interrupt counts with the sum for both node0 and node1. This results in incorrect values for nvme and network interrupt counts per-node.
twitter · Jun 18, 2021 · 31e1a09 · 31e1a09
1 parent b5981ca
commit 31e1a09
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/samplers/interrupt/mod.rs b/src/samplers/interrupt/mod.rs
@@ -216,12 +216,12 @@ impl Interrupt {
                             if let Some(previous) = result.get_mut(&InterruptStatistic::Node0Nvme) {
                                 *previous += node0;
                             } else {
-                                result.insert(InterruptStatistic::Node0Nvme, sum);
+                                result.insert(InterruptStatistic::Node0Nvme, node0);
                             }
                             if let Some(previous) = result.get_mut(&InterruptStatistic::Node1Nvme) {
                                 *previous += node1;
                             } else {
-                                result.insert(InterruptStatistic::Node1Nvme, sum);
+                                result.insert(InterruptStatistic::Node1Nvme, node1);
                             }
                             InterruptStatistic::Nvme
                         }
@@ -232,14 +232,14 @@ impl Interrupt {
                                 {
                                     *previous += node0;
                                 } else {
-                                    result.insert(InterruptStatistic::Node0Network, sum);
+                                    result.insert(InterruptStatistic::Node0Network, node0);
                                 }
                                 if let Some(previous) =
                                     result.get_mut(&InterruptStatistic::Node1Network)
                                 {
                                     *previous += node1;
                                 } else {
-                                    result.insert(InterruptStatistic::Node1Network, sum);
+                                    result.insert(InterruptStatistic::Node1Network, node1);
                                 }
                                 InterruptStatistic::Network
                             } else if label.starts_with("nvme") {
@@ -248,14 +248,14 @@ impl Interrupt {
                                 {
                                     *previous += node0;
                                 } else {
-                                    result.insert(InterruptStatistic::Node0Nvme, sum);
+                                    result.insert(InterruptStatistic::Node0Nvme, node0);
                                 }
                                 if let Some(previous) =
                                     result.get_mut(&InterruptStatistic::Node1Nvme)
                                 {
                                     *previous += node1;
                                 } else {
-                                    result.insert(InterruptStatistic::Node1Nvme, sum);
+                                    result.insert(InterruptStatistic::Node1Nvme, node1);
                                 }
                                 InterruptStatistic::Nvme
                             } else {