Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds packet drops counter to TCP sampler #250

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

rittme
Copy link
Contributor

@rittme rittme commented Oct 27, 2021

Problem

Add a probe to measure TCP packet drops.

Solution

Added a BPF kernel probe to collect the TCP packet drops metrics.

Result

A new metric introduced to TCP sampler: tcp/drop

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2021

CLA assistant check
All committers have signed the CLA.

@WUMUXIAN
Copy link
Contributor

Looks good to me.

@brayniac
Copy link
Contributor

Thanks for the PR!

What's the benefit of using BPF for this metric? We already have TX and RX drops by reading from basic telemetry sources (https://github.com/twitter/rezolus/blob/master/docs/METRICS.md#basic-4) Trying to understand what this offers that isn't already covered.

@WUMUXIAN
Copy link
Contributor

Thanks for the PR!

What's the benefit of using BPF for this metric? We already have TX and RX drops by reading from basic telemetry sources (https://github.com/twitter/rezolus/blob/master/docs/METRICS.md#basic-4) Trying to understand what this offers that isn't already covered.

My understanding of this TX and RX drops are at network device level, it's not necessarily TCP drops. This counter counts packets dropped in the TCP stack, it can be an indicator of two many duplicates, out of order packets, short lived sessions and etc.

docs/METRICS.md Outdated Show resolved Hide resolved
@rittme rittme requested a review from brayniac October 29, 2021 10:09
@rittme
Copy link
Contributor Author

rittme commented Oct 29, 2021

@brayniac, thanks for your review! I tried making the docs clearer. Let me know if this works for you.

Copy link
Contributor

@brayniac brayniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@brayniac brayniac merged commit 6919f05 into twitter:master Oct 29, 2021
@rittme rittme deleted the bpf_tcp_drop branch November 1, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants