remove a few warnings #1720
Merged
remove a few warnings #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushnarang
approved these changes
Sep 23, 2017
| @@ -54,7 +54,7 @@ private[scalding] class ConfPropertiesHfsTap( | |||
| * Changes here however will not show up in the hadoop UI | |||
| */ | |||
| trait HfsConfPropertySetter extends HfsTapProvider { | |||
| @deprecated("Tap config is deprecated, use sourceConfig or sinkConfig directly. In cascading configs applied to sinks can leak to sources in the step writing to the sink.") | |||
| @deprecated("Tap config is deprecated, use sourceConfig or sinkConfig directly. In cascading configs applied to sinks can leak to sources in the step writing to the sink.", "2017-01-12") | |||
There was a problem hiding this comment.
might have been nice if we could tie this to a scalding version. E.g. deprecated since 0.17.1 or so..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to chip away at the giant wall of warnings we have.
review @ttim @ianoc ?