Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace function literals with case classes #1746

Merged
merged 2 commits into from
Oct 21, 2017
Merged

Replace function literals with case classes #1746

merged 2 commits into from
Oct 21, 2017

Conversation

johnynek
Copy link
Collaborator

this addresses #1734

There are two reasons to use case classes for internal functions:

  1. we preserve equality on case classes that wrap them.
  2. we don't accidentally create a closure over something we don't want to serialize

@benpence @ttim @pankajroark @ianoc

@ianoc
Copy link
Collaborator

ianoc commented Oct 21, 2017

lgtm

@johnynek johnynek merged commit d53d06f into develop Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnynek @ianoc