fix(tweet): favs ranked range #1076

bozzelliandrea · 2023-04-01T19:11:00Z

Fixed has_gte_10k_favs range with 10k value instead of 1k

CLAassistant · 2023-04-01T19:15:59Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

shailrshah · 2023-04-02T04:02:31Z

...in/scala/com/twitter/home_mixer/functional_component/decorator/HomeTweetTypePredicates.scala

-      _.getOrElse(EarlybirdFeature, None).exists(_.favCountV2.exists(_ >= 1000))),
+      _.getOrElse(EarlybirdFeature, None).exists(_.favCountV2.exists(_ >= 10000))),


Nice find! Let's use a numeric literal separator.
10000 would become 10_000 for more clarity.

Relevant PR: scala/scala#6989

fix(tweet): favs ranked range

4067882

shailrshah reviewed Apr 2, 2023

View reviewed changes

This was referenced Apr 2, 2023

fix has_gte_10k_favs #1079

Closed

"has_gte_10k_favs" counting for >= 10000 #1561

Closed

twitter-service closed this in d1cab28 Apr 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tweet): favs ranked range #1076

fix(tweet): favs ranked range #1076

bozzelliandrea commented Apr 1, 2023 •

edited

Loading

CLAassistant commented Apr 1, 2023

shailrshah Apr 2, 2023 •

edited

Loading

		_.getOrElse(EarlybirdFeature, None).exists(_.favCountV2.exists(_ >= 1000))),
		_.getOrElse(EarlybirdFeature, None).exists(_.favCountV2.exists(_ >= 10000))),

fix(tweet): favs ranked range #1076

fix(tweet): favs ranked range #1076

Conversation

bozzelliandrea commented Apr 1, 2023 • edited Loading

CLAassistant commented Apr 1, 2023

shailrshah Apr 2, 2023 • edited Loading

Choose a reason for hiding this comment

bozzelliandrea commented Apr 1, 2023 •

edited

Loading

shailrshah Apr 2, 2023 •

edited

Loading