Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendered count bug at async() in dataset.js #1488

Open
xukaifu opened this issue Mar 5, 2016 · 3 comments
Open

rendered count bug at async() in dataset.js #1488

xukaifu opened this issue Mar 5, 2016 · 3 comments

Comments

@xukaifu
Copy link

xukaifu commented Mar 5, 2016

line 272:

          rendered += suggestions.length;
          that._append(query, suggestions.slice(0, that.limit - rendered));

it should be

          that._append(query, suggestions.slice(0, that.limit - rendered));
          rendered += suggestions.length;
@jk3us
Copy link

jk3us commented Mar 8, 2016

It looks like this is the same suggestion in #1481.

@jk3us
Copy link

jk3us commented Mar 8, 2016

Actually, even more discussion at #1415

@jlbooker
Copy link
Contributor

Duplicate of #1212 - Checkout https://github.com/corejavascript/typeahead.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jk3us @xukaifu @jlbooker