Render all async results when there were no sync results

[coopy]

Update rendered-count after async results have displayed. This ensures that all async results are rendered.

[rafaelGuerreiro]

+1. This closes the issue #1232

[gremo]

This. Should be merged because #1200 doesn't work, at least for me. Spent hours of work trying to figure out what was wrong.

[alexfarrill]

+1 this patch worked for me

[theoephraim]

+1
please merge!

[StupidCodeFactory]

+1

[siawyoung]

+1

[razvanphp]

+1
very nasty bug, should be released ASAP.

For me, both PRs work, maybe because my update is called only once..

[Glavin001]

+1 Please merge ASAP!!

[omri]

Please merge

[Glavin001]

I am simply using @per-nilsson 's Fork as my project's dependency, until this is merged and resolved. Without it, I cannot use Tyepahead.js at all.

[aj7]

Please merge asap +1

[thomassnielsen]

Why isn't this merged yet? O_o

[anarkia1985]

You sir are my new favourite person of the month
I've been scratching my head for 1 month wondering what I was doing wrong (without having time to step through the code)

[SebCorbin]

👍 merge please :)

[krazyjakee]

This merge contains fixes for some devastating bugs, why hasn't this been merged and released yet?

[Everlag]

👍 Just migrated from 0.10.5 and this bug had me very confused. Please merge.

[jarthod]

Yes, It's sad they don't maintain this properly.
I can't imagine all the time lost for people diagnosing the same bug over and over again 😕

[hidakatsuya]

👍

[rafaellyra]

please, merge it!

[peter31]

As I see anyone who wants to use remote source for dataset in this library comes to this issue :)
I guess it is a good reason for new minor release.

[BallisticPain]

Wow... this has been an issue for well over a year. I'm using the latest and greatest and we just figured this out. We had no clue why our remote results weren't working!!??!

This claims to be a maintained version of typeahead.js https://github.com/corejavascript/typeahead.js

Hope this helps!

[mdahamiwal]

• 1 for merge. Can someone merge it?

[jarthod]

@mdahamiwal, as you can see in the previous comments, twitter abandoned this repo 1 year ago. The fix is already merged in the community maintained https://github.com/corejavascript/typeahead.js

[jonmaciel]

+1

[pitops]

for rails users add this to your gemfile. Version is 1.0.1 (latest as of this post)

gem 'twitter-typeahead-rails', :git => "git://github.com/pitops/twitter-typeahead-rails.git" , :branch => "bump_version_to_1.0.1"

[dgandini]

The project is abandoned, but the PR worked like a charm.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Per Nilsson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coopy]

lol I signed the agreement. I think you can merge this now ⌛️🚀

[Yinci]

+1 Insane that a PR from over 7 years ago that solves a silent issue is still not merged

[coopy]

a PR from over 7 years ago that solves a silent issue is still not merged

Judging from comment history, this repo is abandoned and replaced by https://github.com/corejavascript/typeahead.js. Hopefully this issue is fixed in that fork!