No suggestions appear if the response count is equal to the limit #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts matched the limit
This was referenced Jul 28, 2017
Closed
patrickhrastnik
added a commit
to HolterDev/typeahead.js
that referenced
this pull request
Jul 30, 2017
I think this might be a valid solution for twitter#1661 (and twitter#1653 )
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the number of suggestions within the JSON response is equal to the suggestion limit, the suggestions are essentially nulled, therefore no suggestions would appear. A slice function was the root cause of this, creating a new suggestions object of size
limit - rendered, which would result in 0 in this case. This has been removed and suggestions now appear when the number of results is the same as the limit.