Simplify the spec to only include the ! nullability designator #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twof
reviewed
Aug 15, 2023
spec/Section 2 -- Language.md
Outdated
| in a query validation error. | ||
| can either use the designator `!` to designate the nullability of the entire | ||
| field, or they can use the list element nullability syntax displayed above. The | ||
| number of dimensions indicated by list element nullability syntax cannot exceed the number of dimensions of the field. Anything else results in a query |
There was a problem hiding this comment.
You may want to have an example where the dimensions of the designator are less than the dimensions of the field type.
There was a problem hiding this comment.
I added some examples after this paragraph.
twof
reviewed
Aug 15, 2023
spec/Section 6 -- Execution.md
Outdated
| nullability designator (`!`) can override it for the duration of an execution. | ||
| In order to determine a field's true nullability, both are taken into account | ||
| and a final type is produced. A field marked with a `!` is called a "required | ||
| field". | ||
|
|
||
| ApplyRequiredStatus(type, requiredStatus): |
There was a problem hiding this comment.
I think I got rid of ApplyRequiredStatus from the execution PR. I think the new function that matters here is called simpleTypeTransfer or something like that.
There was a problem hiding this comment.
I removed ApplyRequiredStatus, defined simpleTypeTransfer, and added references to simpleTypeTransfer. Can you review the list case of ComputeValue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made two changes in this PR:
?nullability designator!.