Add work items section #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizjakubowski
approved these changes
Apr 19, 2021
| PRs will be linked here. | ||
| - Spec Changes | ||
| - Official Libraries | ||
| - GraphQL.js: https://github.com/graphql/graphql-js/pull/2824 |
There was a problem hiding this comment.
let's double check with @xuewei8910 to make sure this PR is ready for external eyes (I think he mentioned it needed to be updated with latest)
rfcs/QueryLevelNullability.md
Outdated
Comment on lines
182
to
188
| - [Apollo Android](https://github.com/apollographql/apollo-android) | ||
| - Code Gen | ||
| - Cache | ||
| - [Apollo iOS](https://github.com/apollographql/apollo-ios) | ||
| - Code Gen | ||
| - Cache | ||
| - [GraphQL Code Generator by The Guild](https://github.com/dotansimha/graphql-code-generator) |
There was a problem hiding this comment.
just wondering: do we need to implement a change for both of these libraries & all 3 platforms for the proof of concept?
There was a problem hiding this comment.
If I'm reading the contribution doc correctly, it looks like we need an implementation in GraphQL.js, and otherwise need to do any implementations needed to address concerns during the review process. Let's confirm during he meeting?
https://github.com/graphql/graphql-spec/blob/main/CONTRIBUTING.md
Co-authored-by: Liz Jakubowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.