#6643: change logging to slf4j-log4j12 (#6845)

twosigma · Feb 13, 2018 · f583711 · f583711
1 parent fcd8566
commit f583711
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/doc/scala/Spark.ipynb b/doc/scala/Spark.ipynb
@@ -17,8 +17,8 @@
    },
    "outputs": [],
    "source": [
-    "%%classpath add mvn\n",
-    "org.apache.spark spark-sql_2.11 2.2.1"
+    "%classpath add mvn org.apache.spark spark-sql_2.11 2.2.1\n",
+    "org.apache.log4j.Logger.getRootLogger().setLevel(org.apache.log4j.Level.ERROR);"
    ]
   },
   {

diff --git a/kernel/base/build.gradle b/kernel/base/build.gradle
@@ -40,7 +40,7 @@ dependencies {
   compile group: 'org.apache.commons', name: 'commons-lang3', version: '3.6'
   compile group: 'org.apache.commons', name: 'commons-text', version: '1.1'
   compile group: 'org.apache.maven.shared', name: 'maven-invoker', version: '3.0.0'
-  compile group: 'org.slf4j', name: 'slf4j-simple', version: '1.7.25'
+  compile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.25'
 
   compile group: "org.zeromq", name: "jeromq", version: "0.3.5"
   compile group: 'org.apache.ivy', name: 'ivy', version: '2.4.0'

diff --git a/...rc/main/resources/simplelogger.properties → .../base/src/main/resources/log4j.properties b/...rc/main/resources/simplelogger.properties → .../base/src/main/resources/log4j.properties
@@ -12,9 +12,8 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
-org.slf4j.simpleLogger.defaultLogLevel=info
-org.slf4j.simpleLogger.showDateTime=true
-org.slf4j.simpleLogger.dateTimeFormat=yyyy-MM-dd HH:mm:ss:SSS Z
-org.slf4j.simpleLogger.showThreadName=true
-org.slf4j.simpleLogger.showLogName=true
-org.slf4j.simpleLogger.showShortLogName=false
+log4j.rootLogger=INFO, stdout
+log4j.appender.stdout=org.apache.log4j.ConsoleAppender
+log4j.appender.stdout.Target=System.out
+log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
+log4j.appender.stdout.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss:SSS Z} [%t] %-5p %c{1} - %m%n