Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 copies of the jars #5781

Closed
scottdraves opened this issue Aug 2, 2017 · 5 comments
Closed

3 copies of the jars #5781

scottdraves opened this issue Aug 2, 2017 · 5 comments
Assignees
@rbidas
Labels
Bug Infrastructure

Comments

@scottdraves
Copy link
Contributor

i am seeing the jars in:

$CONDA_PREFIX/share/jupyter/kernels
$CONDA_PREFIX/share/jupyter/nbextensions/beakerx/kernel

in addition to

$CONDA_PREFIX/lib/python3.5/site-packages/beakerx/static/kernel

which is the only place they belong.
@scottdraves scottdraves mentioned this issue Aug 2, 2017
Closed
@samwincott
Copy link
Contributor

I'd be interested in fixing this, if that's ok?

@scottdraves
Copy link
Contributor Author

scottdraves commented Aug 3, 2017 via email

@altavir
Copy link

altavir commented Aug 18, 2017

Last change removed jar copies from jupyter/kernels but there are still copies in jupyter/nbextensions/beakerx/kernel.

@rbidas
Copy link
Contributor

rbidas commented Sep 19, 2017 •
edited
Loading

after conda clean -all and full developer build in conda directory is only one set of jars in
$CONDA_PREFIX/share/jupyter/nbextensions/beakerx/kernel

@scottdraves
Copy link
Contributor Author

scottdraves commented Sep 19, 2017 •
edited
Loading

yes but 1 set in share and 1 set in lib is 2 sets. we only need 1. as i understand it, the problem is the "jupyter nbextension install" copies the static directory of our python package. so we should put the kernels in beakerx/kernel instead of beakerx/static/kernel to avoid this unneeded copy. should be a way to configure setup.py to include this directory in addition to static.

rbidas added a commit that referenced this issue Sep 25, 2017
@rbidas
#5781 move kernel directory outside static
3725e4a
@rbidas rbidas mentioned this issue Sep 25, 2017
Merged
scottdraves pushed a commit that referenced this issue Oct 30, 2017
@rbidas @scottdraves
#5971 Remove duplicated functionality between setup.py and beakerx-in…
f6aa435 
…stall (#6016)

* #5781 move kernel directory outside static

* #5971 duplicate functionality removed

* #5971 duplicate functionality removed

* #5971 fix build

* #5971 changes after PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbidas rbidas

Labels
Bug Infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@scottdraves @samwincott @rbidas @altavir @jaroslawmalekcodete