#5701 Fixed resetting environment after merge. #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottdraves
reviewed
Jul 27, 2017
| .filter(path -> path.toString().toLowerCase().endsWith(".jar")) | ||
| .collect(Collectors.toMap(p -> p, o -> o.getFileName().toString())); | ||
| .filter(path -> path.toString().toLowerCase().endsWith(".jar")) | ||
| .collect(Collectors.toMap(p -> p, o -> o.getFileName().toString())); | ||
|
|
||
| if (paths == null || paths.isEmpty()) { | ||
| throw new IllegalStateException("Cannot find any jars files in selected path"); |
There was a problem hiding this comment.
as we discussed, this exception is inappropriate for user errors.
use a conditional.
|
please bring up to date with master. |
* origin/master: add tests for kotlin package (#5733) #5737 fix model width update method, handle tab switch in plotScope (adjust width) (#5747) #5741 Catching crash on bad wildcard. (#5745) fix path and add first tests for PloFeatures.ipynb (#5751) Update build for jitpack (#5754) #5628 recreate tooltip interaction (#5744) #5656: eliminate signal warnings (#5735) #5725 Added adjusting import for Kotlin kernel. (#5743) # Conflicts: # kernel/base/src/main/java/com/twosigma/beakerx/kernel/commands/MagicCommand.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.