Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install command for JupyterLab >=3 #97

Merged
merged 1 commit into from
Feb 23, 2024
+2 −2
Merged

Fix install command for JupyterLab >=3 #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions beakerx_tabledisplay/beakerx_tabledisplay/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

def install(args):
subprocess.check_call(["jupyter", "serverextension", "enable", "beakerx_tabledisplay", "--py", "--sys-prefix"])
if LAB_VERSION is not None and LAB_VERSION != 3:
if LAB_VERSION is not None and LAB_VERSION < 3:
subprocess.call(["jupyter", "labextension", "install", "@jupyter-widgets/jupyterlab-manager", "--no-build"],
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
if LAB_VERSION == 1:
Expand All @@ -38,7 +38,7 @@ def uninstall(args):
subprocess.check_call(["jupyter", "nbextension", "disable", "beakerx_tabledisplay", "--py", "--sys-prefix"])
subprocess.check_call(["jupyter", "nbextension", "uninstall", "beakerx_tabledisplay", "--py", "--sys-prefix"])
subprocess.check_call(["jupyter", "serverextension", "disable", "beakerx_tabledisplay", "--py", "--sys-prefix"])
if LAB_VERSION is not None:
if LAB_VERSION is not None and LAB_VERSION < 3:
subprocess.call(["jupyter", "labextension", "uninstall", "beakerx-jupyterlab"],
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)

Expand Down
Loading