feat: find[One]Executable in user-supplied paths #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halostatue
force-pushed
the
find-executable-template-func
branch
2 times, most recently
from
c7072b6 to
186d318
Compare
twpayne
approved these changes
Sep 21, 2023
|
One question before I merge this, @twpayne. Do you prefer I think that the underlying implementation ( |
|
I prefer multiple template functions. This gives stronger type checking, which means bugs are found earlier. |
halostatue
force-pushed
the
find-executable-template-func
branch
from
6d7a64e to
9ad2ddb
Compare
Implemented `findExecutable` with strong caching, extended from twpayne#3162. Also implemented `findOneExecutable` to search for any one executable from a list. Resolves: twpayne#3141 Closes: twpayne#3162 Co-authored-by: Arran Ubels <[email protected]>
halostatue
force-pushed
the
find-executable-template-func
branch
from
9ad2ddb to
8cb3715
Compare
twpayne
approved these changes
Sep 22, 2023
halostatue
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
findExecutablewith strong caching. The main change from#3162 is that it now also accepts either a
fileorfile-listforsearching, so that one of several different options can be searched
simultaneously for roughly equivalent implementations. See #3256 for the
inspiration for this particular change.
We can switch this to two template functions, but I think that the
core implementation would best remain the way that it is.
Resolves: #3141
Closes: #3162
Co-authored-by: Arran Ubels [email protected]