Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust tye init templates to point to tye2 #44

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

Mrxx99
Copy link
Contributor

@Mrxx99 Mrxx99 commented Mar 15, 2024

the templates created with tye2 init were referencing linkt to microsoft tye

It also changes to the raw string literals which makes trimming the start obsolete

@Mrxx99 Mrxx99 requested a review from razvangoga as a code owner March 15, 2024 23:28
@razvangoga
Copy link
Collaborator

@Mrxx99 could you take a look at the comments from my review? i would like to merge this before i do the folder / namespaces rename

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Mar 17, 2024

@razvangoga I don't see any review on this PR.

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Mar 17, 2024

done, I think the file name should also be changed to tye2.yaml, but that can be a separate PR, as maybe other part in code look for tye.yaml for default

@razvangoga
Copy link
Collaborator

razvangoga commented Mar 17, 2024

done, I think the file name should also be changed to tye2.yaml, but that can be a separate PR, as maybe other part in code look for tye.yaml for default

yeah, as a default , the file should probably be called tye2.yaml, but if no file is given as an arg, the app should also look for tye.yaml if no tye2.yaml is there to keep some backwards compatibility

@razvangoga razvangoga merged commit b049d7f into tye-v2:main Mar 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants