fixes

tylerbutler · Aug 1, 2024 · 4b2800e · 4b2800e
1 parent 93f20f6
commit 4b2800e
Showing 1 changed file with 8 additions and 18 deletions.
diff --git a/.github/workflows/release-notes-issue.yml b/.github/workflows/release-notes-issue.yml
@@ -55,22 +55,16 @@ jobs:
 
       - name: Generate release notes file
         run: |
-          flub generate releaseNotes -g client -t minor --out RELEASE_NOTES.md -v
+          flub generate releaseNotes -g client -t minor --includeUnknown --out RELEASE_NOTES.md -v
 
       - name: Read release notes file
         id: relNotes
         uses: juliangruber/read-file-action@v1
         with:
           path: ./RELEASE_NOTES.md
 
-      # - name: Set issue number from push
-      #   id: issueNum
-      #   if: github.event_name == 'push'
-      #   run: echo "ISSUE_NUMBER=26" >> $GITHUB_ENV
-
       - name: Set issue number
         id: issueNum
-        # if: github.event_name == 'workflow_dispatch'
         env:
           ISSUE: ${{ github.event_name == 'push' && '26' || github.event.inputs.issueNumber }}
         run: |
@@ -81,21 +75,17 @@ jobs:
         run: |
           echo "VERSION=$(jq -r '.version' package.json)" >> "$GITHUB_OUTPUT"
 
-      - name: Update issue title
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          ISSUE_NUMBER=${{ steps.issueNum.outputs.ISSUE_NUMBER }}
-          NEW_TITLE="Upcoming Release: FluidFramework v${{ steps.setVersion.outputs.VERSION }}"
-          gh issue edit $ISSUE_NUMBER --title "$NEW_TITLE"
-
       - name: Update issue body
         uses: julien-deramond/update-issue-body@v1
         with:
           issue-number: ${{ steps.issueNum.outputs.ISSUE_NUMBER }}
           body: ${{ steps.relNotes.outputs.content }}
           edit-mode: replace
 
-      # - uses: JasonEtco/create-an-issue@v2
-      #   env:
-      #     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # This job checks that PR template placeholder content has been removed from the PR body.
+      - name: Update issue title
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          ISSUE_NUMBER=${{ steps.issueNum.outputs.ISSUE_NUMBER }}
+          NEW_TITLE="Upcoming Release: FluidFramework v${{ steps.setVersion.outputs.VERSION }}"
+          gh issue edit $ISSUE_NUMBER --title "$NEW_TITLE"