Changes to the build.gradle file to fix the dependance issues #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylrd
reviewed
Apr 10, 2022
| @@ -32,6 +32,7 @@ ProtobufHttpMessageConverter protobufHttpMessageConverter() { | |||
|
|
|||
| @PostMapping(value = "/", produces = "application/json") | |||
| ResponseEntity<Person> createPerson(@RequestBody Person person) { | |||
| DemoRockset d = new DemoRockset(); | |||
There was a problem hiding this comment.
Suggested change
| DemoRockset d = new DemoRockset(); | |
| DemoRockset.main(); |
This will run the code defined in the static method DemoRockset.
Tests will fail with
java.lang.NoClassDefFoundError: com/rockset/client/RocksetClient
at com.tylrd.DemoRockset.main(DemoRockset.java:31)
with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look at the changes made to the build.gradle file. I put some Rockset files in here to make sure the sdk was still able to be imported.