Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlalchemy stubs #68

Merged
merged 5 commits into from
Jul 21, 2021
Merged

Update sqlalchemy stubs #68

merged 5 commits into from
Jul 21, 2021

Conversation

wwuck
Copy link
Contributor

@wwuck wwuck commented Jul 20, 2021

The SQLAlchemy project now provides stubs and a mypy plugin.

The SQLAlchemy project now provides stubs and a mypy plugin.
@wwuck
Copy link
Contributor Author

wwuck commented Jul 20, 2021

Should I have left the existing stubs package in the Readme? The sqlalchemy docs say their stubs are a complete replacement for the existing dropbox stubs package.

These stubs necessarily fully replace the previous sqlalchemy-stubs typing annotations published by Dropbox, as they occupy the same sqlalchemy-stubs namespace as specified by PEP 561.

@orsinium
Copy link
Collaborator

Thank you for your contribution! Yes, let's not replace it for a while and keep both links, please. We can remove sqlalchemy-stubs when (and if) they have an official deprecation notice in the readme. Great if you can open an issue for them to clarify the status of the project.

@orsinium
Copy link
Collaborator

Related: dropbox/sqlalchemy-stubs#195

@wwuck
Copy link
Contributor Author

wwuck commented Jul 20, 2021

Both stubs and plugin for sqlalchemy have the same documentation page which is flagged in CI as a duplicate link.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I was not aware about the second one. Thanks!

@sobolevn
Copy link
Member

Both stubs and plugin for sqlalchemy have the same documentation page which is flagged in CI as a duplicate link.

You can remove one of them.

@sobolevn
Copy link
Member

Thanks!

@sobolevn sobolevn merged commit 89db497 into typeddjango:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants