Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1108

Merged
merged 30 commits into from
Aug 26, 2022
Merged

Fix CI #1108

merged 30 commits into from
Aug 26, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 15, 2022

@sobolevn
Copy link
Member Author

I literally have 0 ideas what is going on.
It all works on my local machine.

@sobolevn
Copy link
Member Author

sobolevn commented Aug 15, 2022

Ok, I figured out that for some reason our CI does not see our stubs. So, everything is just Any.
But, why my local machine works?

At this pace I will be a cheff instead 🤦

@adamchainz
Copy link
Contributor

Personally my backup is goat farmer, it'd be quieter.

@sobolevn
Copy link
Member Author

I like the idea of a sandwich truck, something like this:
truck

Goats are great as well 😆

@sobolevn
Copy link
Member Author

sobolevn commented Aug 22, 2022

Right now there are three things we can do:

  1. Pin mypy<0.970 in pre-commit
  2. Wait for 0.972, I am not sure that we can realease it any time soon
  3. Find some wild way of solving MYPYPATH problems (even author of this feature has no idea what to do)

@adamchainz
Copy link
Contributor

I would vote on pinning mypy<0.970 in CI, as a temporary fix, to allow further PR's to be merged. I'm using django-stubs with 0.971 myself and not having issues - afaiu the problem is limited to the CI setup.

@sobolevn sobolevn merged commit 0bb1182 into master Aug 26, 2022
@sobolevn sobolevn deleted the fix-ci branch August 26, 2022 10:22
@sobolevn
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants