-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0: Update django.contrib.admin.views
and django.forms.forms.Form
metaclass
#2079
5.0: Update django.contrib.admin.views
and django.forms.forms.Form
metaclass
#2079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, double check why stubtest
change is not required.
Yes, there were some stub error occurred like other cases (ex. error: django.contrib.admin.views.main.ChangeList.search_form_class variable differs from runtime type django.forms.forms.DeclarativeFieldsMetaclass
Stub: in file /app/django-stubs/contrib/admin/views/main.pyi:24
Type[django.forms.forms.Form]
Runtime: in file /usr/local/lib/python3.12/site-packages/django/contrib/admin/views/main.py:58
def (*args, **kwargs)
error: django.contrib.admin.views.main.ChangeListSearchForm is inconsistent, metaclass differs
Stub: in file /app/django-stubs/contrib/admin/views/main.pyi:21
N/A
Runtime: in file /usr/local/lib/python3.12/site-packages/django/contrib/admin/views/main.py:58
<class 'django.forms.forms.DeclarativeFieldsMetaclass'> |
Let's update it :) |
I updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One observation, let's avoid Any
where possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this missed the 5.0.0 release, sorry!
django.contrib.admin.views.main
django.contrib.admin.views
and django.forms.forms.Form
metaclass
I have made things!
Update stubs for
django.contrib.admin.views.main
for Django 5.0.django.contrib.admin.views.main
django.contrib.admin.views.main.ChangeList.add_facets
was addeddjango.contrib.admin.views.main.ChangeList.is_facets_optional
was addeddjango.contrib.admin.views.main.ChangeList.filter_params
was addeddjango.contrib.admin.views.main.ChangeList.remove_facet_link
was addeddjango.contrib.admin.views.main.ChangeList.add_facet_link
was addedMissing type stubs were added.
django.contrib.admin.views.main
django.contrib.admin.views.main.ChangeListSearchForm
django.contrib.admin.views.main.ChangeList.search_form_class
Related issues
Refs #1493