-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better rendering for curried functions #714
Comments
Thank you. Will take a look and try to align with the default theme as much as possible. |
Thank you! |
@TomerAberbach The output now correctly renders a single overall comment block above the overload signatures. Each overload has a "Call Signature" heading which easily divides the signatures when scanning the docs. Markdown: HTML: Also output example can be seen here https://github.com/typedoc2md/typedoc-plugin-markdown-scratchpad/blob/main/issues/714/docs/md/functions/includes.md Hope this is acceptable but let me know. |
It looks great, thank you so much! I just went ahead and published it to my new documentation site: https://lfi.dev/docs/api/functions/includes By the way, any reason you're not on GitHub sponsors? |
No problem happy to help and thanks for feedback. I probably should get around to setting up a sponsor page :) |
What package is the feature request related to?
typedoc-plugin-markdown
Background
I'm using
typedocs-plugin-markdown
for a library of mine that has many curried functions, and unfortunately it currently generates overly verbose documentation for those functions.For example, for this function: https://github.com/TomerAberbach/lfi/blob/fd6e1ff9d7b7d249090f89ead6d0a30e26aba2e4/src/operations/predicate.d.ts#L203-L223
I get these docs:
https://github.com/TomerAberbach/lfi/blob/fd6e1ff9d7b7d249090f89ead6d0a30e26aba2e4/docs/functions/includes.md
There are a couple of problems here:
Proposed solution
In terms of prior art, based on the screenshot in this comment, TypeStrong/typedoc#1421 (comment), it seems like the regular typedoc is able to handle this case with some sort of overload signature merging? Might be worth looking into what logic typedoc is doing there. I tried to figure it out, but couldn't nail down where it happens.
The text was updated successfully, but these errors were encountered: