Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added publish settings autoplugin #2860

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

djspiewak
Copy link
Member

Temporary fix until #2857 is ready

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect to be overridden, but 👎

This PR and #2857 both fix publishing to s01. The difference is that this PR supports git worktrees but no Scala3 or JS MiMa, whereas #2857 supports MiMa for all artifacts, but no git worktrees.

And we literally just picked up Scala 3 issues, with MiMa, while testing local release. Unless I'm missing something, there are certainly ways to use git without worktrees, but no-one is checking MiMa unless you configure it :)

I'd like to see a PR that fixes MiMa along with publishing, no preference at all as to how.

@vasilmkd
Copy link
Member

vasilmkd commented Mar 7, 2022

I agree with the sentiment, but for the next major relese 3.4.x. 3.3.7 should take precedence in this case.

@armanbilge
Copy link
Member

Well, I said my piece, and to his credit @djspiewak make a good effort to try and work around this. But it's a long thread of issues with sbt-git and upstream friends unraveling as we pull. So let's not block.

@armanbilge armanbilge dismissed their stale review March 7, 2022 19:28

too many yaks

@djspiewak
Copy link
Member Author

To summarize what @armanbilge and I decided:

  1. Merging this to unblock publication
  2. Releasing the next thing in 3.3.x
  3. I'm going to work on fixing sbt-tl to workaround the jgit issues
  4. We'll migrate CE to sbt-tl directly

@djspiewak djspiewak merged commit d640e49 into typelevel:series/3.3.x Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants