Some small changes for Dotty compatibility #757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes that prepare for Dotty cross-building but are reasonable to do now:
?
with*
, which will be supported in Dotty soon.Function0
.final
on case objects, and it doesn't do anything on Scala 2.do-while
, and recommends the rewrite I've done here..void
or; ()
.BeforeAndAfterAll
but doesn't use any of its methods, and it was causing problems with my local Dotty build of ScalaTest, so I just removed it here.After these changes (and #756) a few other things are necessary to get tests passing on Dotty (see my branch here for a complete list of the additional changes that are needed).
@typeclass
.Any
(see mytopic/dotty-experiment
branch for details).The good news is that if you make all of those changes and publish Dotty and ScalaTest locally, all (core) tests pass on Dotty.