You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I looked at the combineAll implementation, and it seems that acc is initialized as an empty Map, but it isn't changed throughout the function. Maybe that's the cause of the problem.
The text was updated successfully, but these errors were encountered:
These tests will catch sitautions where the optimized methods are
broken (i.e. become inconsistent with the behavior of .combine).
These tests caught an issue with Monoid[Map[K, V]].combineAll, which
was broken.
Fixestypelevel#1346.
These tests will catch sitautions where the optimized methods are
broken (i.e. become inconsistent with the behavior of .combine).
These tests caught an issue with Monoid[Map[K, V]].combineAll, which
was broken.
Fixes#1346.
I was updating my tutorial to Cats 0.7.0 and noticed that combining
Map
s doesn't work as expected.The
combine
method works:However, the
combineAll
method doesn't work:I looked at the combineAll implementation, and it seems that
acc
is initialized as an emptyMap
, but it isn't changed throughout the function. Maybe that's the cause of the problem.The text was updated successfully, but these errors were encountered: