Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cats 0.5.0 no longer pre-release #1042

Merged
merged 1 commit into from
May 17, 2016

Conversation

adamnfish
Copy link
Contributor

Cats 0.5.0 is up in Maven and there's already a 0.6.0-M1 release out as well. This suggests this message is redundant, and it may be encouraging developers to use 0.4.x instead.

@ceedubs
Copy link
Contributor

ceedubs commented May 17, 2016

@adamnfish thanks for raising this concern. It sounds like we may need to work on our wording. What about something like the following?

Note: Cats is still under active development. While we don't anticipate any major redesigns, changes that are neither source nor binary compatibility are to be expected in upcoming cats releases. We will update the minor version of cats accordingly for such changes. Once cats 1.0 is released (ETA: Q3 2016), there will be an increased focus on making changes in compatible ways.

Cats `0.5.0` is up in Maven and there's already a `0.6.0-M1` release
up. With that in mind this message is a little unclear, and may be
suggesting to users that they should use previous releases
(e.g. `0.4.x`). Replacing the `0.5.0` warning with a more general
message about the state of Cats' development is clearer.
@adamnfish adamnfish force-pushed the readme-version-message branch from f814bc2 to e53782a Compare May 17, 2016 10:37
@codecov-io
Copy link

codecov-io commented May 17, 2016

Current coverage is 88.53%

Merging #1042 into master will not change coverage

@@             master      #1042   diff @@
==========================================
  Files           214        214          
  Lines          2719       2719          
  Methods        2655       2655          
  Messages          0          0          
  Branches         59         59          
==========================================
  Hits           2407       2407          
  Misses          312        312          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 0ae8f08...f814bc2

@adamnfish
Copy link
Contributor Author

@ceedubs much better, thanks very much. I've updated the commit.

@ceedubs
Copy link
Contributor

ceedubs commented May 17, 2016

👍

@non
Copy link
Contributor

non commented May 17, 2016

👍 Thanks!

@non non merged commit 2ad272f into typelevel:master May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants