Add a more direct tailRecM law #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
==========================================
+ Coverage 96.13% 96.14% +<.01%
==========================================
Files 273 273
Lines 4530 4535 +5
Branches 116 117 +1
==========================================
+ Hits 4355 4360 +5
Misses 175 175
Continue to review full report at Codecov.
|
|
Merging with two sign-offs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed you can implement flatMap from tailRecM and map. This gives a more direct law for flatMap rather than the limited
A, A => F[A]iterated law that we have currently (since we can takeF[A]andA => F[B]we have less structure on the input, so it is a stronger law.I'd like to add this even though it shouldn't increase test coverage or currently find any bugs, it is a nice documentation of thinking about tailRecM which I continue to think of as a very important method for FlatMap/Monad when thinking about implementations which use bounded stack such as the scala on the jvm.