-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added examples for Cokleisli #1993
Merged
Merged
Changes from 19 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
fb60456
Example for beginners to use Arrow composition
961c1e3
Merge branch 'master' of https://github.com/typelevel/cats
604b71e
Example for beginners to use Arrow composition
6f6b09e
Got rid of whitespace at EOL
4c417aa
Merge branch 'master' of https://github.com/raymondtay/cats
raymondtay 7adc57d
Added type signatures
raymondtay 88abe61
Merge branch 'master' of https://github.com/typelevel/cats
ba82d30
Merge branch 'master' of https://github.com/raymondtay/cats
bcbd847
Got rid of the unused import that is borking the build
raymondtay 5942abb
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay 3ce0002
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay ccab819
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay 5d1a68a
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay 1241d54
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay 64231d5
Merge branch 'master' of https://github.com/raymondtay/cats
raymondtay 185b44e
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay 139c2c4
Merge branch 'master' of https://github.com/raymondtay/cats
raymondtay e7ee56a
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay 782537f
Added examples for dimap,lmap,rmap for Cokleisli
raymondtay 50dd65e
Exchanged the Cokleisli Id examples with NonEmptyList
raymondtay e4396bf
Revert "Exchanged the Cokleisli Id examples with NonEmptyList"
raymondtay 5401b18
Exchanged the Cokleisli examples from 'Id' to use 'NonEmptyList' instead
raymondtay b6cb93d
Merge branch 'master' of https://github.com/typelevel/cats
raymondtay 6a70cea
Removed redundant renderings
raymondtay 517dcea
This is probably safer.
raymondtay 3242791
doh.have not quite woke up yet.
raymondtay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add what this returns here and below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LukaJCB for the reminder, appreciate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnynek thanks for the review and agree with you. Following on your lead, i've revised the examples to use
NonEmptyList
instead, let me know what you think when you look at them?