Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos in typeclasses docs #2377

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

ksonj
Copy link
Contributor

@ksonj ksonj commented Aug 10, 2018

This also moves the section on SemigroupK before MonoidK in the menu

@ksonj ksonj closed this Aug 12, 2018
@ksonj ksonj reopened this Aug 12, 2018
@codecov-io
Copy link

codecov-io commented Aug 12, 2018

Codecov Report

Merging #2377 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2377      +/-   ##
==========================================
+ Coverage   94.73%   95.01%   +0.28%     
==========================================
  Files         349      349              
  Lines        5979     5998      +19     
  Branches      216      221       +5     
==========================================
+ Hits         5664     5699      +35     
+ Misses        315      299      -16
Impacted Files Coverage Δ
laws/src/main/scala/cats/laws/MonadLaws.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Ior.scala 98.48% <0%> (+0.01%) ⬆️
core/src/main/scala/cats/Eval.scala 98.83% <0%> (+0.04%) ⬆️
core/src/main/scala/cats/data/IorT.scala 97.79% <0%> (+0.04%) ⬆️
.../src/main/scala/cats/data/RepresentableStore.scala 87.5% <0%> (+4.16%) ⬆️
core/src/main/scala/cats/syntax/either.scala 99.16% <0%> (+14.16%) ⬆️
testkit/src/main/scala/cats/tests/CatsSuite.scala 70% <0%> (+36.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f47f4...234a776. Read the comment docs.

Kalle Jepsen added 2 commits August 12, 2018 13:18
Analogous to the introduction of Semigroup and Monoid, since SemigroupK
is weaker than MonoidK. Also the SemigroupK section introduces the
notion of kinds, knowledge of which seems to be assumed in the MonoidK
section.
@ksonj ksonj force-pushed the fix/docs-typeclasses branch from 176ac20 to 234a776 Compare August 12, 2018 11:18
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! :)

@LukaJCB LukaJCB merged commit 600e362 into typelevel:master Aug 14, 2018
@ksonj ksonj deleted the fix/docs-typeclasses branch August 14, 2018 15:09
@kailuowang kailuowang added this to the 1.3 milestone Aug 16, 2018
catostrophe pushed a commit to catostrophe/cats that referenced this pull request Sep 15, 2018
* Fix some minor typos

* Move section SemigroupK before MonoidK

Analogous to the introduction of Semigroup and Monoid, since SemigroupK
is weaker than MonoidK. Also the SemigroupK section introduces the
notion of kinds, knowledge of which seems to be assumed in the MonoidK
section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants