WIP: Add Dotty build for kernel only #2629
Conversation
|
We probably need to change sbt release steps to accommodate this change (different crossScalaVersions for different modules). Basically, we need to do this releaseCrossBuild := false,
releaseProcess := Seq[ReleaseStep](
checkSnapshotDependencies,
inquireVersions,
releaseStepCommandAndRemaining("+clean"),
releaseStepCommandAndRemaining("+test"),
setReleaseVersion,
commitReleaseVersion,
tagRelease,
releaseStepCommandAndRemaining("+publishSigned"),
setNextVersion,
commitNextVersion,
releaseStepCommand("sonatypeReleaseAll"),
pushChanges)
also set |
|
re the release, it's currently worse than that. In sbt shell, Additionally, there are no tests in The So...I think next step is to fix the build in interactive sbt so it works cleanly, otherwise I'm not sure we will have much fun moving forward. |
|
The build issues I can/will look at, but I was expecting the It's not a big deal for cats, but I would just to point these out to you in case there is indeed an issue with dotty here. |
No. Dotty right now only uses the Scala 2.12 standard library (so that you can depend on Scala 2.12 projects in your Dotty build). We'll switch to 2.13 once it's released. |
|
Thanks...I'll change that back to 2,12 👍 |
| .jvmSettings(commonJvmSettings ++ mimaSettings("cats-kernel")) | ||
| .settings(libraryDependencies += "org.scalacheck" %%% "scalacheck" % scalaCheckVersion(scalaVersion.value) % "test") |
There was a problem hiding this comment.
If you add .withDottyCompat(scalaVersion.value) you should be able to keep this dependency when compiling with Dotty too (https://github.com/lampepfl/dotty-example-project#getting-your-project-to-compile-with-dotty)
There was a problem hiding this comment.
Oh...I missed that!! Cool
| @@ -878,7 +907,8 @@ lazy val warnUnusedImport = Seq( | |||
| Seq("-Ywarn-unused-import") | |||
| case Some((2, n)) if n >= 12 => | |||
| Seq("-Ywarn-unused:imports") | |||
|
|
|||
| case Some((0, 10)) => | |||
| Seq("-Ywarn-unused:imports") | |||
There was a problem hiding this comment.
That setting doesn't exist in Dotty currently
| @@ -906,6 +936,7 @@ lazy val xlint = Seq( | |||
| scalacOptions += { | |||
| CrossVersion.partialVersion(scalaVersion.value) match { | |||
| case Some((2, scalaMajor)) if scalaMajor >= 12 => "-Xlint:-unused,_" | |||
| case Some((0, 10)) => "-Xlint:-unused,_" | |||
There was a problem hiding this comment.
There's no -Xlint in Dotty currently (and I hope scalafix can completely replace -Xlint)
| @@ -19,3 +19,4 @@ addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.25") | |||
| addSbtPlugin("org.scala-native" % "sbt-scala-native" % "0.3.8") | |||
| addSbtPlugin("com.geirsson" % "sbt-scalafmt" % "1.5.1") | |||
| addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.9.0") | |||
| addSbtPlugin("ch.epfl.lamp" % "sbt-dotty" % "0.2.4") | |||
There was a problem hiding this comment.
Latest is 0.2.6 (looks like we forgot to update the example projects)
There was a problem hiding this comment.
Indeed... my proof that I did Read The Fantastic Manual, but missed the important bit.
|
Since @travisbrown is already working on a Scala 3 / Dotty migration branch, perhaps this one is no longer needed. #3269 |
|
Thanks for the notice, @diesalbla. Closing this one in favour of #3269. |
resolves #2356