Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing T #2688

Closed
wants to merge 1 commit into from
Closed

Add a missing T #2688

wants to merge 1 commit into from

Conversation

andyscott
Copy link
Contributor

Adds a missing T.

@LukaJCB
Copy link
Member

LukaJCB commented Jan 7, 2019

Wait, this is potentially binary breaking, is it not? 🤔

@LukaJCB
Copy link
Member

LukaJCB commented Jan 7, 2019

Yeah seems, like it. I'm gonna file this one for 2.0 :)

@LukaJCB LukaJCB added this to the 2.0 milestone Jan 7, 2019
@mcanlas
Copy link

mcanlas commented Jan 7, 2019

Just driving by. @LukaJCB Is there a resource/document that outlines which changes an author could make that are binary breaking and which are not? And isn't there a tool that helps with this also?

@kailuowang
Copy link
Contributor

Yeah it's BC breaking.

@andyscott
Copy link
Contributor Author

Indeed!

@LukaJCB
Copy link
Member

LukaJCB commented Jan 7, 2019

@mcanlas Check out mima, it's the tool we use and it also describes what's binary breaking :)

@kailuowang
Copy link
Contributor

@mcanlas rule of thumbs is that

  1. you can't change any existing public members.
  2. you can't add a new method to a trait even if you give it a default implementation.

@andyscott if we really care about this name we could simply change the existing to explicit and add a new implicit one with the correct name, although I am not sure if that's better than a miss-spell.

@LukaJCB this would be BC breaking on scala 2.12 as well. For 2.0 we still want 2.12 BC right?

@kailuowang kailuowang modified the milestones: 2.1, 3.0 Feb 5, 2019
@larsrh larsrh closed this Jan 30, 2021
@larsrh larsrh removed this from the 3.0 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants