Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Scala Pets store as an example project #2694

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Conversation

kailuowang
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #2694 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
- Coverage   95.15%   95.15%   -0.01%     
==========================================
  Files         365      365              
  Lines        6770     6849      +79     
  Branches      296      302       +6     
==========================================
+ Hits         6442     6517      +75     
- Misses        328      332       +4
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Kleisli.scala 97.22% <0%> (-0.06%) ⬇️
core/src/main/scala/cats/syntax/bitraverse.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/apply.scala 44.44% <0%> (+19.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6278c...62aa456. Read the comment docs.

@@ -21,6 +21,12 @@ position: 30
* [Scala Exercises](https://www.scala-exercises.org/cats) by 47 Degrees
offers multiple online exercises to learn about the type classes and
datatypes included in Cats.

# Examples
* [Scala Pets Store](https://github.com/pauljamescleary/scala-pet-store)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "Scala Pet Store"

* [Scala Pets Store](https://github.com/pauljamescleary/scala-pet-store)
An implementation of the java pet store using FP techniques in scala. Stack includes Http4s, Circe,
Doobie, Cats, ScalaCheck, and PureConfig.

Copy link

@pauljamescleary pauljamescleary Jan 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrates FP techniques while maintaining approachability for people with an OO background. Uses tagless final for the core domain, and popular Typelevel libraries including Cats, Http4s, Circe and Doobie

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LukaJCB
LukaJCB previously approved these changes Jan 12, 2019
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have done this soon, thanks @kailuowang! :)

An implementation of the java pet store using FP techniques in scala. Stack includes Http4s, Circe,
Doobie, Cats, ScalaCheck, and PureConfig.
Doobie, Cats, and ScalaCheck. Demonstrates FP techniques while maintaining approachability for people with an OO background. Uses tagless final for the core domain, and popular Typelevel libraries including Cats, Http4s, Circe and Doobie

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kailuowang can you remove the first two sentences An implementation of the java pet store using FP techniques in scala. Stack includes Http4s, Circe, Doobie, Cats, ScalaCheck, and PureConfig. The description should start with Demonstrates FP techniques

@kailuowang kailuowang merged commit 2e203e1 into master Jan 15, 2019
@kailuowang kailuowang deleted the kailuowang-patch-3 branch January 15, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants