Make WrappedMutableMapBase extend Serializable #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are running into Spark `Task not serializable` issues when a closure that executes on a Spark executor node involves a `Map` that is created via running `foldMap` on a `List`. This commit makes the `WrappedMutableMap` hierarchy extend `Serializable` and chex that the cerealization works (this test failed before extending `Serializable`).
Codecov Report
@@ Coverage Diff @@
## master #2784 +/- ##
==========================================
- Coverage 94.68% 94.65% -0.03%
==========================================
Files 365 365
Lines 6869 6869
Branches 293 293
==========================================
- Hits 6504 6502 -2
- Misses 365 367 +2
Continue to review full report at Codecov.
|
tpolecat
approved these changes
Apr 10, 2019
|
Are we all just going to pretend we didn't see those puns? |
rossabaker
pushed a commit
to rossabaker/cats
that referenced
this pull request
May 26, 2019
We are running into Spark `Task not serializable` issues when a closure that executes on a Spark executor node involves a `Map` that is created via running `foldMap` on a `List`. This commit makes the `WrappedMutableMap` hierarchy extend `Serializable` and chex that the cerealization works (this test failed before extending `Serializable`).
rossabaker
added a commit
that referenced
this pull request
Jun 3, 2019
* Change MonadErrorOps#reject so it no longer runs effects twice (#2810) * Add regression test for MonadErrorOps bug * Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes #2809 * Fix Order.max and Oder.min description comments (#2842) Changed description to better fit their implentation * Make WrappedMutableMapBase extend Serializable (#2784) We are running into Spark `Task not serializable` issues when a closure that executes on a Spark executor node involves a `Map` that is created via running `foldMap` on a `List`. This commit makes the `WrappedMutableMap` hierarchy extend `Serializable` and chex that the cerealization works (this test failed before extending `Serializable`). * Optimize productR in Apply (#2728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into Spark
Task not serializableissues when a closurethat executes on a Spark executor node involves a
Mapthat is createdvia running
foldMapon aList. This commit makes theWrappedMutableMaphierarchy extendSerializableand chex that thecerealization works (this test failed before extending
Serializable).