Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more doctest to Ior #3063

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

hamednourhani
Copy link
Contributor

Re: Issue #2479

Add more doctest to Ior methods:

  • fold
  • putLeft
  • putRight
  • isLeft
  • isRight
  • isBoth
  • left
  • right
  • onlyLeft
  • onlyRight
  • onlyRightOrLeft
  • onlyBoth
  • pad
  • unwrap
  • toIorNes
  • toIorNel
  • toEither
  • toValidated
  • toOption
  • toList
  • to
  • swap
  • exists
  • forall
  • getOrElse
  • valueOr
  • bimap
  • leftMap
  • map
  • flatMap
  • foldLeft
  • combine

@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #3063 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3063      +/-   ##
==========================================
+ Coverage   93.46%   93.48%   +0.01%     
==========================================
  Files         368      368              
  Lines        6979     6979              
  Branches      184      184              
==========================================
+ Hits         6523     6524       +1     
+ Misses        456      455       -1
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Ior.scala 98.52% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/semigroup.scala 75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d07788...44d9a77. Read the comment docs.

@hamednourhani
Copy link
Contributor Author

Hi @kailuowang . would you please review this PR.
And one question : what is the process of adding PRs to merged branches

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@larsrh larsrh merged commit eafa140 into typelevel:master Oct 5, 2019
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants