Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't understand that the values in Maps were also combined when two maps are combined - I thought the
"hello" -> 2
entry was simply replacing the"hello" -> 0
entry in the first map. Giving the first map's"hello"
a value of1
results in the combined map having a"hello" -> 3
entry, showing that the values were combined.After understanding that, I realized why my code couldn't find an implicit
Semigroup
for my Map - I didn't have an implicitSemigroup
for my map's values.Thank you for contributing to Cats!
This is a kind reminder to run
sbt prePR
and commit the changed files, if any, before submitting.