Move adaptError #3148
Merged
Move adaptError #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Codecov Report
@@ Coverage Diff @@
## master #3148 +/- ##
=========================================
Coverage ? 93.28%
=========================================
Files ? 376
Lines ? 7323
Branches ? 200
=========================================
Hits ? 6831
Misses ? 492
Partials ? 0
Continue to review full report at Codecov.
|
fthomas
previously approved these changes
Nov 14, 2019
rossabaker
reviewed
Nov 14, 2019
| @@ -124,8 +124,7 @@ final class ApplicativeErrorOps[F[_], E, A](private val fa: F[A]) extends AnyVal | |||
| * }}} | |||
| * | |||
| * This is the same as `MonadErrorOps#adaptError`. It cannot have the same name because | |||
| * this would result in ambiguous implicits. `adaptError` will be moved from `MonadError` | |||
| * to `ApplicativeError` in Cats 2.0: see [[https://github.com/typelevel/cats/issues/2685]] | |||
| * this would result in ambiguous implicits. | |||
| */ | |||
| def adaptErr(pf: PartialFunction[E, E])(implicit F: ApplicativeError[F, E]): F[A] = | |||
| F.recoverWith(fa)(pf.andThen(F.raiseError[A] _)) | |||
There was a problem hiding this comment.
Nit: is there any reason to keep a duplicate implementation, now that it's on the constraint?
There was a problem hiding this comment.
Agreed, thanks for catching this!
|
Okay, conflict is resolved and implementation is de-duplicated. I've also added some syntax tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2685.
Unfortunately I don't think we can fix the syntax without breaking bincompat due to a compiler bug: #2685 (comment)