-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Scalafmt to 2.4.2 #3337
Update Scalafmt to 2.4.2 #3337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3337 +/- ##
==========================================
+ Coverage 93.31% 93.31% +<.01%
==========================================
Files 378 378
Lines 7688 7689 +1
Branches 206 206
==========================================
+ Hits 7174 7175 +1
Misses 514 514
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this format as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly don't like deviating from the defaults, but I'm persuaded on this one.
Thanks all! We can always reconsider going back to defaults later. |
This is a more conservative version of #3315 that still rewrites
{ }
to( )
for single-line expressions, but doesn't remove newlines in cases like this, which was my primary complaint about the default config in 2.4.2:In #3315 that got rewritten to the following, which obscures what's being tested, at least to my eyes:
Instead of
+495 −1,432
it's+58, −50
, so quite a bit less dramatic, and the changes look more reasonable to me.