Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semigroup instance for OneAnd #545

Merged
merged 2 commits into from
Sep 27, 2015
Merged

Add Semigroup instance for OneAnd #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eceefc
Add Semigroup instance for OneAnd
liff Sep 27, 2015
1817081
Add tests for Semigroup instance of OneAnd
liff Sep 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/scala/cats/data/OneAnd.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ trait OneAndInstances extends OneAndLowPriority1 {
a combine b
}

implicit def oneAndSemigroup[F[_]: MonadCombine, A]: Semigroup[OneAnd[A, F]] =
oneAndSemigroupK.algebra

implicit def oneAndFoldable[F[_]](implicit foldable: Foldable[F]): Foldable[OneAnd[?,F]] =
new Foldable[OneAnd[?,F]] {
override def foldLeft[A, B](fa: OneAnd[A, F], b: B)(f: (B, A) => B): B =
Expand Down
4 changes: 3 additions & 1 deletion tests/src/test/scala/cats/tests/OneAndTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package cats
package tests

import algebra.laws.OrderLaws
import algebra.laws.{GroupLaws, OrderLaws}

import cats.data.{NonEmptyList, OneAnd}
import cats.laws.discipline.{ComonadTests, FunctorTests, SemigroupKTests, FoldableTests, MonadTests, SerializableTests}
Expand All @@ -24,7 +24,9 @@ class OneAndTests extends CatsSuite {
{
implicit val monadCombine = ListWrapper.monadCombine
checkAll("OneAnd[Int, ListWrapper]", SemigroupKTests[OneAnd[?, ListWrapper]].semigroupK[Int])
checkAll("OneAnd[Int, List]", GroupLaws[OneAnd[Int, List]].semigroup)
checkAll("SemigroupK[OneAnd[A, ListWrapper]]", SerializableTests.serializable(SemigroupK[OneAnd[?, ListWrapper]]))
checkAll("Semigroup[NonEmptyList[Int]]", SerializableTests.serializable(Semigroup[OneAnd[Int, List]]))
}

{
Expand Down