Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the Contravariant instance of Function1 #578

Merged
merged 1 commit into from
Oct 18, 2015
Merged

Test the Contravariant instance of Function1 #578

merged 1 commit into from
Oct 18, 2015

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 18, 2015

No description provided.

@codecov-io
Copy link

Current coverage is 76.15%

Merging #578 into master will increase coverage by +0.45% as of abfc9fe

@@            master    #578   diff @@
======================================
  Files          157     158     +1
  Stmts         2165    2172     +7
  Branches        68      68       
  Methods          0       0       
======================================
+ Hit           1639    1654    +15
  Partial          0       0       
+ Missed         526     518     -8

Review entire Coverage Diff as of abfc9fe

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Oct 18, 2015

👍 wonderful thank you!

This makes me realize that we are missing a Contravariant instance for Kleisli, aren't we? Are there any other types that come to mind that should have a Contravariant instance?

@ceedubs
Copy link
Contributor

ceedubs commented Oct 18, 2015

I think I've found a few. I'll open a separate issue.

@ceedubs ceedubs mentioned this pull request Oct 18, 2015
Closed
@non
Copy link
Contributor

non commented Oct 18, 2015

👍

non added a commit that referenced this pull request Oct 18, 2015
@non
Merge pull request #578 from fthomas/topic/covariant-tests
fda67ae 
Test the Contravariant instance of Function1
@non non merged commit fda67ae into typelevel:master Oct 18, 2015
@non non removed the in progress label Oct 18, 2015
@fthomas fthomas deleted the topic/covariant-tests branch September 6, 2017 11:50
@kailuowang kailuowang modified the milestone: 1.0.0-RC1 Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fthomas @codecov-io @ceedubs @non @kailuowang