Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for separate from MonadCombine. #975

Merged
merged 2 commits into from
Apr 21, 2016

Conversation

peterneyens
Copy link
Collaborator

I based myself on the structure in syntax.bitraverse for the two implicit conversions (the
existing for unite and the new for separate).

MonadCombine separate was added in #864 by @adelbertc.

I based myself on the structure in syntax.bitraverse for the two implicit conversions (the
existing for unite and the new for separate).

MonadCombine separate was added in typelevel#864 by @adelbertc.
@codecov-io
Copy link

Current coverage is 90.88%

Merging #975 into master will increase coverage by +0.01% as of 04498e9

@@            master    #975   diff @@
======================================
  Files          181     181       
  Stmts         2160    2162     +2
  Branches        42      42       
  Methods          0       0       
======================================
+ Hit           1963    1965     +2
  Partial          0       0       
  Missed         197     197       

Review entire Coverage Diff as of 04498e9

Powered by Codecov. Updated on successful CI builds.

@ceedubs
Copy link
Contributor

ceedubs commented Apr 12, 2016

👍 looks good. Thanks!

@adelbertc
Copy link
Contributor

Hm what is the motivation of calling it "nested" and having it in a MonadCombineSyntax1 as opposed to just the MonadCombineSyntax?

@peterneyens
Copy link
Collaborator Author

I followed the same structure as in the bitraverse syntax.

MonadCombineSyntax1 doesn't seem necessary yes (and neither does BitraverseSyntax1 ?)

Should I rename NestedMonadCombineOps to SeparateOps (like FlattenOps and IfMOps in the flatMap syntax?

@peterneyens
Copy link
Collaborator Author

I have renamed the NestedMonadCombineOps to SeparateOps and moved the implicit conversion into MonadCombineSyntax.

I have also added a test for MonadCombine in SyntaxTests. Am I right that this file just needs to compile, for the tests to be valid ?

@ceedubs
Copy link
Contributor

ceedubs commented Apr 18, 2016

👍 looks good to me. Thanks @peterneyens!

@non
Copy link
Contributor

non commented Apr 21, 2016

Looks good to me. 👍

@non non merged commit d8917df into typelevel:master Apr 21, 2016
@peterneyens peterneyens deleted the add-monadcombine-separate-syntax branch April 27, 2016 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants