-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SemigroupK instance for Validated + tests #998
Add SemigroupK instance for Validated + tests #998
Conversation
Similar to my other PR on adding a |
Looks great. Thanks @aaronlevin! 👍, but we should get the build issues figured out before we merge so we don't throw more variables into the mix. |
It occurs to me that it might also be handy to create a |
@ceedubs since we're waiting for the build stuff to get fixed, I'm happy to update this PR tonight (EU time) with your suggestion :) |
Closing and reopening to pick up build fixes. |
👍 At some point I think it would be good for us to follow up on this comment. I'm happy for that to be a separate effort though. |
@ceedubs i think it's a good idea, but i can submit another PR with that change. is cats |
@aaronlevin it is and it would be :). We have a convention of waiting for two 👍s before merging, so that's all we are waiting on for this PR as far as I'm concerned. |
👍 |
No description provided.