Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context propagation? #7

Closed
fiadliel opened this issue Apr 3, 2018 · 3 comments · Fixed by #86
Closed

Add context propagation? #7

fiadliel opened this issue Apr 3, 2018 · 3 comments · Fixed by #86

Comments

@fiadliel
Copy link
Contributor

fiadliel commented Apr 3, 2018

grpc-java includes opencensus integration, which allows tracing of requests across a call graph. While this would be nice to have, I don't think the context is propagated across asynchronous call boundaries (it's in a ThreadLocalStorage).

Should investigate possible ways of making this context available.
@fiadliel
Copy link
Contributor Author

fiadliel commented Apr 3, 2018

Some possible supporting info/context at grpc/grpc-java#2984

@addisonj
Copy link

Ah just ran into this... (not for tracing, just for doing some auth)

This all makes sense why it doesn't work, but wonder if it would be worth to add a small note into the README in the event anyone runs into this

@rossabaker
Copy link
Member

Yeah, PR would be welcome on that limitation.

I don't follow opencensus very closely, but maybe chasing where this left off would be a start toward fixing it.

Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Jul 31, 2019
@Tapped
Add gRPC Context propagation
099d88a 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
@Tapped Tapped mentioned this issue Jul 31, 2019
Merged
Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Aug 1, 2019
@Tapped
Add gRPC Context propagation
c966c66 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Aug 1, 2019
@Tapped
Add gRPC Context propagation
6af0293 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Aug 19, 2019
@Tapped
Add gRPC Context propagation
8474613 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Aug 19, 2019
@Tapped
Add gRPC Context propagation
5cc1f3a 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Aug 19, 2019
@Tapped
Add gRPC Context propagation
8494541 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Aug 19, 2019
@Tapped
Add gRPC Context propagation
25456d4 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
Tapped added a commit to cognitedata/fs2-grpc that referenced this issue Sep 17, 2019
@Tapped
Add gRPC Context propagation
4953a3e 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
wjoel pushed a commit to cognitedata/fs2-grpc that referenced this issue May 4, 2020
@Tapped @wjoel
Add gRPC Context propagation
879425d 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
wjoel pushed a commit to cognitedata/fs2-grpc that referenced this issue May 4, 2020
@Tapped @wjoel
Add gRPC Context propagation
cb2465d 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
wjoel pushed a commit to cognitedata/fs2-grpc that referenced this issue May 4, 2020
@Tapped @wjoel
Add gRPC Context propagation
9419467 
It grabs the Context from the same thread as the thread used for gRPC,
and then forks and attaches it to the thread used when calling into
the gRPC stub implementation (async boundary).

Close typelevel#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add gRPC Context propagation cognitedata/fs2-grpc
3 participants
@rossabaker @addisonj @fiadliel