scalapb upgrade #31
Merged
scalapb upgrade #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fs2-grpc failed. Built with commit 62f3bfe https://app.netlify.com/sites/fs2-grpc/deploys/5ba8ad834ed62f5ddde6712b |
rossabaker
reviewed
Sep 24, 2018
|
😁 |
|
A small change needed. Obviously some scripted tests would benefit here! (comment on scripted tests is a note to myself) |
fiadliel
suggested changes
Sep 25, 2018
| private[this] def serviceMethodSignature(method: MethodDescriptor) = { | ||
| s"def ${method.name}" + (method.streamType match { | ||
| case StreamType.Unary => | ||
| s"(request: ${method.scalaIn}, clientHeaders: _root_.io.grpc.Metadata): F[${method.scalaOut}]" | ||
| s"(request: ${method.inputType}, clientHeaders: _root_.io.grpc.Metadata): F[${method.outputType}]" |
There was a problem hiding this comment.
This needs to be ${method.inputType.scalaType}
Same for other cases below.
- upgrade to ScalaPB 0.8.0 - adjust `Fs2GrpcPlugin` and `GrpcServicePrinter` to changes done with respect to `DescriptorImplicits` class that previously was trait `DescriptorPimps`.
|
@fiadliel done |
fiadliel
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade to ScalaPB 0.8.0
adjust
Fs2GrpcPluginandGrpcServicePrintertochanges done with respect to
DescriptorImplicitsclass that previously was trait
DescriptorPimps.