Add trailers metadata support in unary response methods #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalkingFoxMid
force-pushed
the
metadata_trailers_support
branch
from
3882588 to
bb49357
Compare
Closed
TalkingFoxMid
force-pushed
the
metadata_trailers_support
branch
3 times, most recently
from
4392ed0 to
3294a3e
Compare
TalkingFoxMid
force-pushed
the
metadata_trailers_support
branch
from
3294a3e to
75b9ba9
Compare
|
@ahjohannessen will check? |
|
I do not have the bandwidth to review currently, unfortunately :/ I can take a look when I find the time. |
|
We are also interested in this feature. Is there any hope that you will do a review soon? |
a-khakimov
approved these changes
May 28, 2024
|
@TalkingFoxMid Can you remove the companion object of Edit: Nevermind, I'll merge and remove it. |
|
Did a v2.7.15 release - Should be on sonatype soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This merge request introduces the capability for servers to send custom metadata (trailers) in responses for unaryToUnary and clientStreaming methods using the fs2.grpc library. Prior to this change, metadata was automatically filled with empty values, with no option for the server to specify or send custom metadata. This enhancement opens up the flexibility for server implementations to include additional information in their responses, providing a richer communication protocol between clients and servers.
Changes
In this Merge Request, the generation of additional traits and objects with the "Trailers" suffix is added, supporting GRPC trailers metadata. In the signature of the newly generated traits, two methods are modified: noStreaming and clientStreaming. This means that, in these two types of GRPC handlers, the server will be able to specify which metadata it wishes to return, and the client will be able to retrieve this metadata